Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve CSS issues in the roadmap item modal #1918

Merged
merged 6 commits into from
Jul 17, 2023
Merged

fix: resolve CSS issues in the roadmap item modal #1918

merged 6 commits into from
Jul 17, 2023

Conversation

codingmickey
Copy link
Contributor

Description

Fixed the overlay issue also in smaller screens too

  • Laptop
    image

  • Tablet
    image

  • Phone
    image
    image

Related issue(s)
Closes #1906

@codingmickey
fix: CSS issues in the roadmap item modal
d7a0cff 
Signed-off-by: Kartik Jolapara <kjmickey003@gmail.com>
github-actions[bot]
github-actions bot reviewed Jul 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@netlify
Copy link

netlify bot commented Jul 8, 2023 •
edited
Loading

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2a33a46
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/64b4e0ef27423b000950651a
😎 Deploy Preview https://deploy-preview-1918--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jul 8, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 57
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1918--asyncapi-website.netlify.app/

@codingmickey codingmickey mentioned this pull request Jul 8, 2023
Closed
derberg
derberg reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the PR title and also remove any changes not related to the scope of the PR, like extra spaces, semi colons and any stuff that your auto-formatter added.

unless you want us to continue with #1919

@codingmickey codingmickey changed the title fix: CSS issues in the roadmap item modal fix: resolve CSS issues in the roadmap item modal Jul 11, 2023
@codingmickey
fix: formatting changes in Modal.js
22cc54a 
Signed-off-by: Kartik Jolapara <kjmickey003@gmail.com>
@codingmickey
Copy link
Contributor Author

codingmickey commented Jul 11, 2023 •
edited
Loading

please fix the PR title and also remove any changes not related to the scope of the PR, like extra spaces, semi colons and any stuff that your auto-formatter added.

unless you want us to continue with #1919

Really sorry about this :(

Made the required fixes

@codingmickey
Copy link
Contributor Author

codingmickey commented Jul 11, 2023 •
edited
Loading

If possible @derberg I would suggest to add a .prettierrc file so the formatting is taken care of..?

akshatnema
akshatnema requested changes Jul 12, 2023
View reviewed changes
components/Modal.js Outdated Show resolved Hide resolved
@derberg derberg mentioned this pull request Jul 12, 2023
Closed
@codingmickey codingmickey requested a review from Mayaleeeee as a code owner July 15, 2023 12:41
codingmickey and others added 2 commits July 15, 2023 18:16
@codingmickey @akshatnema
refactor: applying the suggestion of height fixes in different viewpo…
c6091d1 
…rts of the modal in `/roadmap`

Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
@codingmickey
Merge branch 'master' into fix/roadmap_modal
2858c75
@akshatnema
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit ac4dad3 into asyncapi:master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@akshatnema akshatnema akshatnema approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@Mayaleeeee Mayaleeeee Awaiting requested review from Mayaleeeee Mayaleeeee is a code owner

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overlay bug in the /roadmap
4 participants
@codingmickey @akshatnema @derberg @asyncapi-bot